[vlc-devel] [PATCH 1/4] filters: flush before closing filters

Rémi Denis-Courmont remi at remlab.net
Tue Oct 13 08:37:41 CEST 2020


 I don't think that's correct. A filter could very well want to drain rather than flush at close, or whatever. It's no surprise that flushing is often done at close but I don't think it should be forced.

And then it makes reading the code more difficult, as it's nonobvious that Flush would be called implicitly at exit. Soon we'd see Close -> Flush calls being added again to fix nonexistent leaks.
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201013/b7e20787/attachment.html>

More information about the vlc-devel mailing list