[vlc-devel] [PATCH] contrib: disable Rust on Winstore builds

Thomas Guillem thomas at gllm.fr
Tue Oct 13 13:11:04 CEST 2020


Patch LGTM.

We were using a wrong target for winstore: x86_64-pc-windows-gnu instead of x86_64-uwp-windows-gnu, hence the usage of forbidden APIs. I guess it worked by luck in Rust 1.46.0.

On Tue, Oct 13, 2020, at 07:56, Steve Lhomme wrote:
> It's using some forbidden API's in UWP:
> https://code.videolan.org/videolan/vlc/-/jobs/462281
> 
> - 
> https://docs.microsoft.com/en-us/windows/win32/api/tlhelp32/nf-tlhelp32-createtoolhelp32snapshot
> - 
> https://docs.microsoft.com/en-us/windows/win32/api/tlhelp32/nf-tlhelp32-module32firstw
> - 
> https://docs.microsoft.com/en-us/windows/win32/api/tlhelp32/nf-tlhelp32-module32nextw
> 
> Not sure it's related to rav1e or Rust in general.
> ---
>  contrib/src/main-rust.mak | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/contrib/src/main-rust.mak b/contrib/src/main-rust.mak
> index 36ca76d8ef5..fe2be827249 100644
> --- a/contrib/src/main-rust.mak
> +++ b/contrib/src/main-rust.mak
> @@ -4,6 +4,7 @@
>  # This file is under the same license as the vlc package.
>  
>  ifdef HAVE_WIN32
> +ifndef HAVE_WINSTORE

Add a comment # *-uwp-windows-gnu is Tier 3

>  ifeq ($(HOST),i686-w64-mingw32)
>  RUST_TARGET = i686-pc-windows-gnu # ARCH is i386
>  else ifeq ($(HOST),x86_64-w64-mingw32)
> @@ -11,6 +12,7 @@ RUST_TARGET = $(ARCH)-pc-windows-gnu
>  else
>  # Not supported on armv7/aarch64 yet
>  endif
> +endif
>  else ifdef HAVE_ANDROID
>  RUST_TARGET = $(HOST)
>  else ifdef HAVE_IOS
> -- 
> 2.26.2
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list