[vlc-devel] [PATCH 3/6] vout: drawable: restore drawable for OS/2

[Steve Lhomme]

On 2020-10-13 15:02, KO Myung-Hun wrote:
> Hi/2.
> 
> Steve Lhomme wrote:
>> On 2020-10-12 13:00, KO Myung-Hun wrote:
>>> Hi/2.
>>>
>>> Steve Lhomme wrote:
>>>> On 2020-10-11 13:00, KO Myung-Hun wrote:
>>>>> This is from commit 72c10ed11fde80.
>>>>
>>>> The current Makefile.am already builds libdrawable_plugin.la for OS/2.
>>>> It's using the win32/drawable.c. So I think the commit title is
>>>> misleading.
>>>>
>>>
>>> Because it's for Win32 not for OS/2. You made Win32-OS/2-common
>>> drawable.c Win32-specific. I asked to split codes for two platforms, but
>>> it was not accepted. So, I think, title has no problem. Or any
>>> suggestion ?
>>
>> Implement OS/2 specific version of HWND drawable.
>>
>>
> 
> Ok. Fixed.
> 
>>>> Also the commit you point out just changes one line in RemoveDrawable().
>>>> I doubt that's the commit that broke the whole thing.
>>>>
>>>
>>> I don't know what you are saying `one line'. But this patch is very
>>> before Win32-specefic codes were added. Of course, Win32-specific codes
>>> will do not work on OS/2.
>>
>> That patch does:
>> -    if (n == 0)
>> +    if (n == 1)
>>
>> I highly doubt that's what makes the code that worked in OS/2 not work
>> anymore.
>>
> 
> The code has no problems at all. In addition, the code had already been
> included in this patch. I'm afraid I don't understand why you are saying
> about the code.
> 
> As comment message says, this patch is from 72c10ed11fde80 including the
> code.

My understanding was that this commit broke the OS/2 support. Now I 
understand it's the last known working version.

>>>> Your version looks a lot like the win32 but without any event loop. In
>>>> particular it doesn't implement vout_window_ReportSize() or
>>>> vout_window_ReportClose() which must be implemented by window modules if
>>>> their size change or when they are closed.
>>>
>>> Of course, original drawable.c is common for OS/2 and Win32.
>>> Anyway, I'll try to implement them. Thanks for your advice.
>>>
> 
> I'll implement those features later.
> 
> Thanks.
> 
> -- 
> KO Myung-Hun
> 
> Using Mozilla SeaMonkey 2.7.2
> Under OS/2 Warp 4 for Korean with FixPak #15
> In VirtualBox v6.1.10 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
> 
> Korean OS/2 User Community : http://www.os2.kr/
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>