[vlc-devel] [PATCH v3 1/14] core: add config_GetTempPath()

Lyndon Brown jnqnfe at gmail.com
Wed Oct 14 20:58:44 CEST 2020


On Wed, 2020-10-14 at 08:17 +0200, Steve Lhomme wrote:
> It would be better if this code was not duplicated for different
> windows 
> target. You can put it in win32/filesystem.c for example.

If people are happy for it to live in the filesystem file then that's
absolutely fine by me, happy to avoid the duplication.

Attached is a replacement for patches #1 and #4, the former to address
your comment and the latter just to fix a commit log typo.

An alternative to these two revised patches will be submitted in a
moment to address Remi's comment, though it's not certain that a change
is truly wanted in that case, so one pair or the other will need to be
used depending upon that decision.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01.patch
Type: text/x-patch
Size: 3120 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/0e4cb042/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 04.patch
Type: text/x-patch
Size: 1579 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/0e4cb042/attachment-0001.bin>


More information about the vlc-devel mailing list