[vlc-devel] [PATCH v2 09/20] deinterlace: implement draining of extra pictures

[Steve Lhomme]

On 2020-10-14 18:25, Rémi Denis-Courmont wrote:
> Le keskiviikkona 14. lokakuuta 2020, 15.39.09 EEST Steve Lhomme a écrit :
>> Each filter using the common deinterlacing code now calls DoDrain (similar
>> to DoDeinterlacing) to do its draining.
> 
> That does not sound like what is usually called draining, which means to
> process all buffers *before* an end or a discontinuity.

Happy to use another term if there is one.

>> We no longer return pictures chained using vlc_picture_chain_AppendChain().
> 
> This seems odd too.

That's my whole goal with this "draining". To handle extra pictures 
explicitly and consistently, forced by the API. Not have some rare 
places (display for deinterlace, transcode for deinterlace/fps) handle 
it manually and leave everything else up to 
interpretation/guessing/parsing hundreds of modules.

As a transition I could do #16-#20 with just the picture and 
picture_chain API's that can do this properly. And then we can 
transition them to "drain" calls.