[vlc-devel] [PATCH v3 0/14] mkstemp

Lyndon Brown jnqnfe at gmail.com
Wed Oct 14 04:51:02 CEST 2020


v3 of the mkstemp work.

 - takes into account review comments from v2.
 - adds a commit (#7) adding brief documentation to vlc_mkstemp.
 - adds a commit (#4) implementing another use of config_GetTempPath.
 - makes vlc_MakeTmpFile() inline because there are so few users.
 - drops v2 commit #8 since after the changes diff was too tiny.
 - drops v2 commit #9 since no longer needed.
 - moves the close FD calls in the vorepository & record module
changes.
 - adds commits (#12&13) modifying es_out_timeshift to make use of
tmpfile() and obsoleting --input-timeshift-path, as previously
discussed.
 - adds a commit (#14) to switch record over to using vlc_memfd() for
probing muxers.

Commits #4-6 I'm sure someone will point out are redundant since #12
deletes the code they change. I wanted to keep them in place, mostly in
case for any reason #12&13 ends up being rejected, or reverted at some
later point. I'd prefer keeping them in place.

The very last commit was rather hastily put together just now having
been struggling to understand what Remi had meant the other day, and
having been struggling these past few days to get much work at all
done. I'm not certain whether any changes are needed in the standard
sout plugin to get it actually working. I hope it's what Remi was
after, and I hope it's correct as it is.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01.patch
Type: text/x-patch
Size: 3496 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02.patch
Type: text/x-patch
Size: 2052 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03.patch
Type: text/x-patch
Size: 4009 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 04.patch
Type: text/x-patch
Size: 1578 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 05.patch
Type: text/x-patch
Size: 2254 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 06.patch
Type: text/x-patch
Size: 1191 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 07.patch
Type: text/x-patch
Size: 1443 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 08.patch
Type: text/x-patch
Size: 1873 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 09.patch
Type: text/x-patch
Size: 3044 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 10.patch
Type: text/x-patch
Size: 1421 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 11.patch
Type: text/x-patch
Size: 2318 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 12.patch
Type: text/x-patch
Size: 8322 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13.patch
Type: text/x-patch
Size: 1398 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 14.patch
Type: text/x-patch
Size: 4603 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: all.zip
Type: application/zip
Size: 17162 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201014/f18733b1/attachment.zip>


More information about the vlc-devel mailing list