[vlc-devel] [PATCH v2 09/20] deinterlace: implement draining of extra pictures

[Steve Lhomme]

On 2020-10-15 15:30, Rémi Denis-Courmont wrote:
> Hi,
> 
> I could just as well ask why you claim that this patchset implements GPU 
> filtering, when we already had working GPU filtering in VLC 3.x... While 
> this patchset addresses your objections to the earlier sink-based 
> patchset, it does not addresses mine which I already laid out at length 
> back then.
> 
> Furthermore, it does not implement drain as we have understood it in 
> VLC, does not address the video filter drain ticket (and therefore, it 
> shouldn't occupy the video drain callback slot in filter_t).

Looking at #12155 it says
"Indeed some video filters introduce a delay, notably deinterlacing 
filters."

It sounds like the drain that would be done to fix that ticket is 
exactly the function I called Drain in my implementations. Only it's 
called more often.

> Le 15 octobre 2020 14:39:34 GMT+03:00, Alexandre Janniaux 
> <ajanni at videolabs.io> a écrit :
> 
>     Hi,
> 
>     On Thu, Oct 15, 2020 at 02:02:02PM +0300, Rémi Denis-Courmont wrote:
> 
>         Hi,
> 
>         That's not draining and it cannot be treated the same way. For
>         that, you need asynchronous filtering, in other words with owner
>         callbacks.
> 
>         Exactly what I just said and what I'd also pointed out earlier...
> 
> 
>     I implemented it without asynchronous filtering, so I'm not sure to
>     see why we «need» them?
> 
>     Regards,
>     --
>     Alexandre Janniaux
>     Videolabs
>     ------------------------------------------------------------------------
>     vlc-devel mailing list
>     To unsubscribe or modify your subscription options:
>     https://mailman.videolan.org/listinfo/vlc-devel
> 
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>