[vlc-devel] [PATCH v2 09/20] deinterlace: implement draining of extra pictures

[Alexandre Janniaux]

Hi,

On Thu, Oct 15, 2020 at 04:30:21PM +0300, Rémi Denis-Courmont wrote:
> Hi,
>
> I could just as well ask why you claim that this patchset implements GPU filtering, when we already had working GPU filtering in VLC 3.x... While this patchset addresses your objections to the earlier sink-based patchset, it does not addresses mine which I already laid out at length back then.

I'm not sure I understand your point. I never claimed that
this patchset implements GPU filtering, I've only mentioned
that moving the backpressure back in the pipeline was good
for GPU buffers and my work is not about GPU filtering, but
more precisely GPGPU filtering with OpenGL.

This patchset is not what I wrote anyway so I'm neither
defending nor approving it yet. I've exposed my requirements
in the work that I did before Steve's one, the details I've
been dealing with too, and you asserted that it could not
work.

Since I actually did use the filter pipeline like I described,
I'm quite curious why you are saying that it cannot work in
the following sentence.

> That's not draining and it cannot be treated the same way. For that,
> you need asynchronous filtering, in other words with owner callbacks.

I also don't understand what kind of backpressure you want to
have and which execution model you want with asynchronous
filtering.

> Furthermore, it does not implement drain as we have understood it in VLC, does not address the video filter drain ticket (and therefore, it shouldn't occupy the video drain callback slot in filter_t).

That I agree on, but IMHO it's filter pipeline client issue,
better expressed with a dedicated discontinuity signal. Though
I personnally don't care how it's done since it doesn't exist
yet.

Regards,
--
Alexandre Janniaux
Videolabs

> Le 15 octobre 2020 14:39:34 GMT+03:00, Alexandre Janniaux <ajanni at videolabs.io> a écrit :
> >Hi,
> >
> >On Thu, Oct 15, 2020 at 02:02:02PM +0300, Rémi Denis-Courmont wrote:
> >> Hi,
> >>
> >> That's not draining and it cannot be treated the same way. For that,
> >you need asynchronous filtering, in other words with owner callbacks.
> >>
> >> Exactly what I just said and what I'd also pointed out earlier...
> >
> >I implemented it without asynchronous filtering, so I'm not sure to
> >see why we «need» them?
> >
> >Regards,
> >--
> >Alexandre Janniaux
> >Videolabs
> >_______________________________________________
> >vlc-devel mailing list
> >To unsubscribe or modify your subscription options:
> >https://mailman.videolan.org/listinfo/vlc-devel
>
> --
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel