[vlc-devel] [PATCH v2 09/20] deinterlace: implement draining of extra pictures

[Steve Lhomme]

On 2020-10-15 17:00, Rémi Denis-Courmont wrote:
> Le torstaina 15. lokakuuta 2020, 17.06.07 EEST Steve Lhomme a écrit :
>> On 2020-10-15 15:30, Rémi Denis-Courmont wrote:
>>> Hi,
>>>
>>> I could just as well ask why you claim that this patchset implements GPU
>>> filtering, when we already had working GPU filtering in VLC 3.x... While
>>> this patchset addresses your objections to the earlier sink-based
>>> patchset, it does not addresses mine which I already laid out at length
>>> back then.
>>>
>>> Furthermore, it does not implement drain as we have understood it in
>>> VLC, does not address the video filter drain ticket (and therefore, it
>>> shouldn't occupy the video drain callback slot in filter_t).
>>
>> Looking at #12155 it says
>> "Indeed some video filters introduce a delay, notably deinterlacing
>> filters."
> 
> Literally, the first sentence from my bug report:
> 
> "Decoders can be drained to avoid loosing the last output packets at the end
> of stream. "
> 
> And the second sentence:
> 
> "A similar mechanism is necessary for video filters."
> 
> Obviously not what this patch is doing. So now you are obviously trolling.
> 
> Plonk, -1.

It's hard to reply constructively with such replies. Ignored.