[vlc-devel] [PATCH] Restore compatibility with recent SRT library

[Julien Montant]

Hi,

That's not about this particular case. The library dependency SRT is not 
listed on the dependency list of VLC, that's all. Therefore, there is no 
information at all on what version is supported by VLC.

The `SRTO_LATENCY` macro has always (as of git releases, v1.2.3 in march 
2018 ) been an alias to the `SRTO_TSBPDDELAY` macro. This change 
shouldn't break backward compatibility and no define should be needed.

Best.

PS: I'm new here and I didn't know I should reply to the whole list.

PPS: Please don't hesitate to point me to resources to better use the 
mailing list.

On 2020-10-13 22:13, Francois Cartegnie wrote:
> Le 13/10/2020 à 21:45, Julien Montant a écrit :
>
>> srt_set_socket_option( access_obj, SRT_PARAM_LATENCY, p_sys->sock,
>> -            SRTO_TSBPDDELAY, &i_latency, sizeof(i_latency) );
>> +            SRTO_LATENCY, &i_latency, sizeof(i_latency) );
>>         /* set passphrase */
>>       if (psz_passphrase != NULL && psz_passphrase[0] != '\0') {
>>
> Do we have a way to check the lib version to add a define instead ?
>
> I don't see why a library value rename would need bumping the 
> requirements.
>
On 2020-10-13 22:13, Francois Cartegnie wrote:
> Le 13/10/2020 à 21:45, Julien Montant a écrit :
>
>>       srt_set_socket_option( access_obj, SRT_PARAM_LATENCY, p_sys->sock,
>> -            SRTO_TSBPDDELAY, &i_latency, sizeof(i_latency) );
>> +            SRTO_LATENCY, &i_latency, sizeof(i_latency) );
>>   
>>       /* set passphrase */
>>       if (psz_passphrase != NULL && psz_passphrase[0] != '\0') {
>>
> Do we have a way to check the lib version to add a define instead ?
>
> I don't see why a library value rename would need bumping the requirements.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201016/7093c994/attachment.html>