[vlc-devel] [PATCH] Fix Basic Digest Auth

Maxim De Clercq maximdeclercq00 at gmail.com
Fri Oct 16 21:49:25 CEST 2020


*Commit message*
Revert: old http: fix leak on reconnect

Do not reinitialized the auth state machine at every connection because it
breaks digest authentication.

*Explanation*
This patch fixes digest authentication by reverting a leak fix that seems
to have introduced this bug. By reinitializing the auth every connection,
it is not possible to retain information about the digest, which causes the
call to vlc_http_auth_FormatAuthorizationHeader in modules/access/http.c to
default to Basic Authentication, which always causes a 401.

Please refer to this issue
<https://code.videolan.org/videolan/vlc-android/-/issues/1412> for more
information.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201016/039d0784/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Revert__old_http__fix_leak_on_reconnect.patch
Type: application/x-patch
Size: 1507 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201016/039d0784/attachment.bin>


More information about the vlc-devel mailing list