[vlc-devel] [PATCH 3/3] macosx: Add explanatory strings more access to restricted resources

[Marvin Scholz]

On 17 Oct 2020, at 13:26, david.fuhrmann at gmail.com wrote:

> From: David Fuhrmann <dfuhrmann at videolan.org>
>
> Those strings are read directly by the mac OS to show some reason
> in ressource request dialogs.
>
> The strings for NSAppleEventsUsageDescription, 
> NSCameraUsageDescription
> and NSMicrophoneUsageDescription are mandatory, otherwise the
> application will crash.
>
> InfoPlist.strings needs to be translated to show localized variants
> of those strings.
>
> refs #21378
> ---
>  modules/gui/macosx/Resources/InfoPlist.strings | 11 ++++++++---
>  share/Info.plist.in                            | 16 +++++++++++++---
>  2 files changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/modules/gui/macosx/Resources/InfoPlist.strings 
> b/modules/gui/macosx/Resources/InfoPlist.strings
> index 2f109b7715e..251abd87473 100644
> --- a/modules/gui/macosx/Resources/InfoPlist.strings
> +++ b/modules/gui/macosx/Resources/InfoPlist.strings
> @@ -1,5 +1,10 @@
>  /* Localized versions of Info.plist keys */
>
> -"NSCameraUsageDescription" = "VLC uses the camera to record some 
> video.";
> -"NSMicrophoneUsageDescription" = "VLC uses the microphone to record 
> some audio.";
> -"NSAppleEventsUsageDescription" = "VLC uses apple events to control 
> external media players.";
> +"NSCameraUsageDescription" = "VLC wants to access the camera as 
> requested by the user.";
> +"NSMicrophoneUsageDescription" = "VLC wants to access the microphone 
> as requested by the user.";
> +"NSAppleEventsUsageDescription" = "VLC wants to pause and resume 
> external media players.";
> +"NSDesktopFolderUsageDescription" = "VLC wants to access the desktop 
> folder as requestd by the user.";

Typo: requested

> +"NSDocumentsFolderUsageDescription" = "VLC wants to access the 
> documents folder as requestd by the user.";

Typo: requested

> +"NSDownloadsFolderUsageDescription" = "VLC wants to access the 
> downloads folder as requestd by the user.";

Typo: requested

> +"NSNetworkVolumesUsageDescription" = "VLC wants to access a network 
> volume as requestd by the user.";

Typo: requested

> +"NSRemovableVolumesUsageDescription" = "VLC wants to access a 
> removable volume as requestd by the user.";

Typo: requested

> diff --git a/share/Info.plist.in b/share/Info.plist.in
> index d106a87b6d8..7c90ade2273 100644
> --- a/share/Info.plist.in
> +++ b/share/Info.plist.in
> @@ -62,11 +62,21 @@
>  	<key>NSHumanReadableCopyright</key>
>  	<string>Copyright (c) @COPYRIGHT_YEARS@ VLC authors and 
> VideoLAN</string>
>  	<key>NSCameraUsageDescription</key>
> -	<string>VLC uses the camera to record some video.</string>
> +	<string>VLC wants to access the camera as requested by the 
> user.</string>
>  	<key>NSMicrophoneUsageDescription</key>
> -	<string>VLC uses the microphone to record some audio.</string>
> +	<string>VLC wants to access the microphone as requested by the 
> user.</string>
>  	<key>NSAppleEventsUsageDescription</key>
> -	<string>VLC uses apple events to control external media 
> players.</string>
> +	<string>VLC wants to pause and resume external media 
> players.</string>
> +	<key>NSDesktopFolderUsageDescription</key>

Same typos as above

> +	<string>VLC wants to access the desktop folder as requestd by the 
> user.</string>
> +	<key>NSDocumentsFolderUsageDescription</key>
> +	<string>VLC wants to access the documents folder as requestd by the 
> user.</string>
> +	<key>NSDownloadsFolderUsageDescription</key>
> +	<string>VLC wants to access the downloads folder as requestd by the 
> user.</string>
> +	<key>NSNetworkVolumesUsageDescription</key>
> +	<string>VLC wants to access a network volume as requestd by the 
> user.</string>
> +	<key>NSRemovableVolumesUsageDescription</key>
> +	<string>VLC wants to access a removable volume as requestd by the 
> user.</string>
>  	<key>CFBundleDocumentTypes</key>
>  	<array>
>  		<dict>
> -- 
> 2.21.1 (Apple Git-122.3)
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel