[vlc-devel] [PATCH 14/16] video_output: rename ambiguous refresh flag to redisplay_needed

Rémi Denis-Courmont remi at remlab.net
Sat Oct 17 16:20:07 CEST 2020


Le lauantaina 17. lokakuuta 2020, 16.41.43 EEST Alexandre Janniaux a écrit :
> Hi,
> 
> I'm not sure why the renaming is needed, refresh is both for non
> compositing window manager (see xrefresh)

Not really. It's primarily there to refresh OSD during pause or with a slow 
frame rate.

If the vout display plugin is not composited, it can (and should) hold the 
last picture and redraw it upon a damage event or a change of picture 
placement. There are no needs for the core to know about that. In fact, to 
handle partial damage in optimised fashion, you really don't want the core to 
be involved.

Refreshing the display in the core is just legacy bug compatibility.

-- 
Реми Дёни-Курмон
http://www.remlab.net/





More information about the vlc-devel mailing list