[vlc-devel] [PATCH 3.0] qt: fix changing rate (coarse) does not display OSD messages
Rémi Denis-Courmont
remi at remlab.net
Mon Oct 19 14:09:08 CEST 2020
Le maanantaina 19. lokakuuta 2020, 11.07.38 EEST Pierre Lamot a écrit :
> Changing the player ratet through the hotkeys does display the rate on OSD
> whereas changing directly the rate in the player doesn't.
Generally speaking, I don't think interfaces should be injecting hotkeys. If
some hotkeys code is useful elsewhere, it should be moved to core.
No objections because this is only for 3.0, though.
> ---
> modules/gui/qt/input_manager.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/modules/gui/qt/input_manager.cpp
> b/modules/gui/qt/input_manager.cpp index ede449141f..5aee413ff4 100644
> --- a/modules/gui/qt/input_manager.cpp
> +++ b/modules/gui/qt/input_manager.cpp
> @@ -894,12 +894,12 @@ void InputManager::reverse()
>
> void InputManager::slower()
> {
> - var_TriggerCallback( THEPL, "rate-slower" );
> + var_SetInteger( p_intf->obj.libvlc, "key-action", ACTIONID_SLOWER );
> }
>
> void InputManager::faster()
> {
> - var_TriggerCallback( THEPL, "rate-faster" );
> + var_SetInteger( p_intf->obj.libvlc, "key-action", ACTIONID_FASTER );
> }
>
> void InputManager::littlefaster()
--
雷米‧德尼-库尔蒙
http://www.remlab.net/
More information about the vlc-devel
mailing list