[vlc-devel] [PATCH] contrib: rnnoise: prefix common symbols

[Thomas Guillem]

We have the same kind issue with a recent version of libsmb2 on iOS.

There is a crash in the md5 helper (MD5Init(), MD5Update()...).
These symbols are found in other contribs and VLC. The linker doesn't output any errors, but there is a crash from MD5Update(). I guess smb2 use the symbol of a contrib and it's not expected.
What is the correct solution to fix this issue?
Android doesn't seem to have any issue with that (static link).

On Tue, Oct 20, 2020, at 10:33, Rémi Denis-Courmont wrote:
> Hi,
> 
> No, there is nothing unavoidable about it.
> Partial linking is the only way to avoid overlapping symbols with different definitions, and is the only supported way to link VLC modules statically. Anything else is known broken for well over a decade.
> 
> But that's not even the problem here. Multiple equivalent definitions of the same function in different libraries is fine even without partial linking. If there is a duplicate symbol error the build flags are wrong, very very wrong.
> 
> This patch is only (yet again) highlighting bugs elsewhere.
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201020/b7fbe990/attachment.html>