[vlc-devel] [PATCH 1/5] vout: update the format after filters

[Rémi Denis-Courmont]

Le keskiviikkona 21. lokakuuta 2020, 8.49.59 EEST Steve Lhomme a écrit :
> On 2020-10-20 18:32, Rémi Denis-Courmont wrote:
> > Le tiistaina 20. lokakuuta 2020, 18.06.53 EEST Romain Vimont a écrit :
> >> On Tue, Oct 20, 2020 at 05:02:58PM +0300, Rémi Denis-Courmont wrote:
> >>> Hi,
> >>> 
> >>> We have already covered this in (audio and) video-related IRL
> >>> discussions
> >>> and concluded every time that the current system is the least bad.
> >> 
> >> Hmmm, I'm not sure (especially in discussions about push).
> > 
> > In the pure ultimate push model, filters are created from upstream to
> > downstream, and the output is created last, supplied with the output
> > format of the filter chain. When the filter chain is changed, all
> > downstream elements (filters if any, and output) are destroyed and
> > recreated. Visual glitches are
> I don't think this model can ever happen. There will always be
> differences between what the last (automatic+user) filter produces and
> what a display module can accept. The "osys->converters" will always
> need to be there (called p_final_conv_static in the transcoder). In this
> case the converter doesn't push an output format but is forced to use
> one. So, at least converters, would need to work in a non-push way.

The current model does not work without converters. The patchset does not work 
without converters either, and the push model would not work without 
converters.

I don't really get your point. That model is nothing new. It was already the 
main highlight behind the first push-model discussion ~3 years ago. It's really 
just extending the asynchronous push model from the decoder to the filter 
chain.

-- 
Реми Дёни-Курмон
http://www.remlab.net/