[vlc-devel] [PATCH] demux: json: add json_reader context
Rémi Denis-Courmont
remi at remlab.net
Wed Oct 21 19:45:09 CEST 2020
Le keskiviikkona 21. lokakuuta 2020, 19.18.45 EEST Alexandre Janniaux a écrit
:
> Having the indirection at the API level is much easier to
> read and understand, and is just an additional hop for error
> cases which should not happen in the nominal case anyway.
> That's quite the same anyway, so I'm no sure I see why a
> link-time indirection should be valid with calling VLC
> logger inside, whereas API-level indirection doing the
> same would not be valid.
You could just as well move the logging code into the parser. I just don't
really see the point in stacking *two* levels of indirection.
As for the input code, it was originally just the default. I only switched it
to integrate the VLC interrupt API.
--
レミ・デニ-クールモン
http://www.remlab.net/
More information about the vlc-devel
mailing list