[vlc-devel] [PATCH 1/4] vlc_tick: from_samples: Use uint64_t for samplerate

Thomas Guillem thomas at gllm.fr
Thu Oct 22 09:55:50 CEST 2020


It should be unsigned yes, but why 64 bits? 

The higher we can find is 192 kHz. Knowing that 48kHz is very well suited for user playback. I think we are far from the 32bit limit ;)

On Thu, Oct 22, 2020, at 09:49, Hugo Beauzée-Luyssen wrote:
> ---
>  include/vlc_tick.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/vlc_tick.h b/include/vlc_tick.h
> index 517eff1a44..1416be9034 100644
> --- a/include/vlc_tick.h
> +++ b/include/vlc_tick.h
> @@ -97,7 +97,7 @@ static inline vlc_tick_t vlc_tick_rate_duration(float 
> frame_rate)
>  /*
>   * samples<>vlc_tick_t
>   */
> -static inline vlc_tick_t vlc_tick_from_samples(int64_t samples, int 
> samp_rate)
> +static inline vlc_tick_t vlc_tick_from_samples(int64_t samples, 
> uint64_t samp_rate)
>  {
>      return CLOCK_FREQ * samples / samp_rate;
>  }
> -- 
> 2.20.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list