[vlc-devel] [PATCH 1/4] vlc_tick: from_samples: Use uint64_t for samplerate

[Hugo Beauzée-Luyssen]

Indeed,

I split it out of the first set, with more changes to the callsites: https://code.videolan.org/chouquette/vlc/-/merge_requests/24
For now it's still using uint64_t though

On Thu, Oct 22, 2020, at 9:59 AM, Steve Lhomme wrote:
> I see some calls using a signed integer (dcp, directsound, 
> opensles_android, avformat/demux, etc) it's probably wrong but they 
> should probably be corrected first. Did you try to compile it on all the 
> CI targets ?
> 
> On 2020-10-22 9:49, Hugo Beauzée-Luyssen wrote:
> > ---
> >   include/vlc_tick.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/vlc_tick.h b/include/vlc_tick.h
> > index 517eff1a44..1416be9034 100644
> > --- a/include/vlc_tick.h
> > +++ b/include/vlc_tick.h
> > @@ -97,7 +97,7 @@ static inline vlc_tick_t vlc_tick_rate_duration(float frame_rate)
> >   /*
> >    * samples<>vlc_tick_t
> >    */
> > -static inline vlc_tick_t vlc_tick_from_samples(int64_t samples, int samp_rate)
> > +static inline vlc_tick_t vlc_tick_from_samples(int64_t samples, uint64_t samp_rate)
> >   {
> >       return CLOCK_FREQ * samples / samp_rate;
> >   }
> > -- 
> > 2.20.1
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr