[vlc-devel] [PATCH 1/5] vout: update the format after filters

Rémi Denis-Courmont remi at remlab.net
Thu Oct 22 17:07:46 CEST 2020


Le torstaina 22. lokakuuta 2020, 12.00.51 EEST Romain Vimont a écrit :
> > > That's not true for GPU filters.
> > 
> > That's of course true for all types of filters.
> 
> No, that's not true for GPU filters.

Yes it is, as shown two major versions supporting GPU filters already.

> For example, producing an I420 output could require to execute a filter
> 3 times, one for each output plane, to 3 different textures.

That has nothing to do with what format is exposed at the core level.

> > Gratuitious conversions may be
> > passable in audio output, but they're a massive wastage of computing
> > resource in video.
> 
> That's one of the reason we want to avoid adding an useless converter
> and request the vout to accept the new format directly.

You can't have it both ways. If there are no gratuitious change of format, 
then this patch is unnecessary anyway.

Again, the vout display is free to request a different format than the decoder 
outputs, to avoid unnecessary conversions. That's how GPU pass-through already 
works for several years. Without breaking prioritisation, fallback and without 
requiring a new callback just for special snowflake GL output.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the vlc-devel mailing list