[vlc-devel] [PATCH 2/2] taglib: detect charset when ID3v2 Latin-1 parser finds invalid character

Souju TANAKA sojulibra at gmail.com
Sat Oct 24 11:15:14 CEST 2020


On 2020/10/23 19:54, Francois Cartegnie wrote:
> Le 23/10/2020 à 12:46, sojulibra at gmail.com a écrit :
>> From: Souju TANAKA <sojulibra at gmail.com>
>>
>> Changed TagLib Latin-1 parser to check whether a ISO 8859-1 encoded ID3v2 tag
>> is a valid byte sequence. If invalid Latin-1 character is found, try to detect
>> charset and convert the tag into UTF-8 to avoid Mojibake.
>>
>> Some encoder embeds ID3v2 in unexpected charset, though it is againt the spec.
>> TagLib allows to overide TagLib::ID3v2::Latin1StringHandler::parse() to deal
>> with this practical situation.
> 
> we already provide a dedicated function to fix utf8 encodings
> 

I'm not willing to touch or fix unicode meta string of ID3v2.

-- 
Souju TANAKA


More information about the vlc-devel mailing list