[vlc-devel] [PATCH 01/21] libvlc: use str_id to compare different es

[Prince Gupta]

> Rémi Denis-Courmont wrote:
> That looks suspicious and there are zero explanations, so no thanks.

I was told that i_id is deprecated, in my tests, every vlc_es_id_t::i_id
was zero (or something same, basically their values were all same) and was
causing issues when multiple subtitles were selected at once.

Kind regards
Prince Gupta

On Fri, Oct 23, 2020 at 6:52 PM Prince Gupta <guptaprince8832 at gmail.com>
wrote:

> ---
>  src/input/es_out.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/input/es_out.c b/src/input/es_out.c
> index beae1e9b55..326a125f49 100644
> --- a/src/input/es_out.c
> +++ b/src/input/es_out.c
> @@ -2672,7 +2672,7 @@ static void EsOutSelectList( es_out_t *out, enum
> es_format_category_e cat,
>                  vlc_es_id_t *es_id = es_id_list[i];
>                  if( es_id == NULL )
>                      break;
> -                else if( es_id->i_id == other->id.i_id )
> +                else if( !strcmp( es_id->str_id, other->id.str_id ) )
>                  {
>                      select = true;
>                      break;
> --
> 2.25.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20201024/9399796b/attachment.html>