[vlc-devel] [PATCH VLC-3] libvlc-module: fix sout-keep longtext

[Alexandre Janniaux]

Hi,

Note that VLC 4 suffers from the same issue, so I can also make this
patch for VLC 4 and backport to VLC 3. Since it's documentation, it's
usually not reviewed but since it has been there for a long time, we
probably want to review why it has been written like this.

I originally made the patch for VLC 3 when reviewing the code for the
VLC user documentation.

Regards,
--
Alexandre Janniaux
Videolabs

On Tue, Oct 27, 2020 at 10:09:19AM +0100, Alexandre Janniaux wrote:
> The longtext help is implying that --sout-keep will automatically add
> the gather stream output filter which is not accurate.
>
> It has never been the case as seen in original commit adding this:
> 4b7cff4d248bea925e6bb19157f6a65aed3f3788.
> ---
>  src/libvlc-module.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/libvlc-module.c b/src/libvlc-module.c
> index 79dfb9d5ae..8d913c7e9b 100644
> --- a/src/libvlc-module.c
> +++ b/src/libvlc-module.c
> @@ -958,8 +958,7 @@ static const char *const ppsz_prefres[] = {
>  #define SOUT_KEEP_TEXT N_("Keep stream output open" )
>  #define SOUT_KEEP_LONGTEXT N_( \
>      "This allows you to keep an unique stream output instance across " \
> -    "multiple playlist item (automatically insert the gather stream output " \
> -    "if not specified)" )
> +    "multiple playlist item." )
>
>  #define SOUT_MUX_CACHING_TEXT N_("Stream output muxer caching (ms)")
>  #define SOUT_MUX_CACHING_LONGTEXT N_( \
> --
> 2.29.1