[vlc-devel] [PATCH 2/2] chromecast: don't close the client connection

[Alexandre Janniaux]

Hi,

This probably need a bit more rationale since infinite timeout
is always discutable. You could add that the «timeout» is still
handled as the server handle the playback, and it will finish at
some points.

Otherwise LGTM for both patches.

Regards,
--
Alexandre Janniaux
Videolabs

On Tue, Oct 27, 2020 at 05:28:00PM +0100, Thomas Guillem wrote:
> Fixes #25151
> Fixes #25192
> ---
>  modules/stream_out/chromecast/cast.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/modules/stream_out/chromecast/cast.cpp b/modules/stream_out/chromecast/cast.cpp
> index 08defbd5a1b..12e175bc68a 100644
> --- a/modules/stream_out/chromecast/cast.cpp
> +++ b/modules/stream_out/chromecast/cast.cpp
> @@ -466,6 +466,13 @@ int sout_access_out_sys_t::url_cb(httpd_client_t *cl, httpd_message_t *answer,
>           * should also serve data used by the old client to the new one. */
>          restoreCopy();
>          m_client = cl;
> +
> +        /* Chromecast clients buffer lot of data (burst mode) and can wait more
> +         * than 10 seconds between 2 consecutive reads. Tell httpd that the
> +         * timeout of this client should not be handled (infinite timeout) to
> +         * avoid closing the client connection after 10 seconds without any
> +         * read. */
> +        httpd_ClientSetTimeout(m_client, 0);
>      }
>
>      /* Send data per 512kB minimum */
> --
> 2.28.0
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel