[vlc-devel] [PATCH 2/2] chromecast: don't close the client connection

[Rémi Denis-Courmont]

Le tiistaina 27. lokakuuta 2020, 18.28.00 EET Thomas Guillem a écrit :
> Fixes #25151
> Fixes #25192
> ---
>  modules/stream_out/chromecast/cast.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/modules/stream_out/chromecast/cast.cpp
> b/modules/stream_out/chromecast/cast.cpp index 08defbd5a1b..12e175bc68a
> 100644
> --- a/modules/stream_out/chromecast/cast.cpp
> +++ b/modules/stream_out/chromecast/cast.cpp
> @@ -466,6 +466,13 @@ int sout_access_out_sys_t::url_cb(httpd_client_t *cl,
> httpd_message_t *answer, * should also serve data used by the old client to
> the new one. */ restoreCopy();
>          m_client = cl;
> +
> +        /* Chromecast clients buffer lot of data (burst mode) and can wait
> more
> +         * than 10 seconds between 2 consecutive reads.

Linux limits the TCP send window to 4 MiB by default for security reasons.So 
at, say 15 seconds, between reads, the stream would be capped at 2 Mbps... And 
there are probably OSes with even lower limits.

I have to doubt the accuracy of the statement because it should have been a 
major problem from the beginning. But if it's true, then it's a client bug 
that this patchset won't be able to work around.

-- 
Rémi Denis-Courmont
http://www.remlab.net/