[vlc-devel] [PATCH 2/4] httpd: update poll timeout with clients timeouts

Rémi Denis-Courmont remi at remlab.net
Wed Oct 28 15:26:33 CET 2020


Le keskiviikkona 28. lokakuuta 2020, 14.34.35 EET Thomas Guillem a écrit :
> Use the lowest timeout of all clients.
> 
> This fixes client timeouts that were not always strictly respected.
> Indeed, poll was waiting indefinitely by default so timeouts were only
> handled after a socket event was processed.

We *can*, and maybe should, do that in 4.0.

In practice though, if there is a new connection, poll() will wake up and time 
out the old connections anyway. As such, dead connections cannot inflate the 
peak number of connections. It's not an urgent problem.

For risk management reasons, I would rather not do this belongs in 3.0 unless 
there is an actual bug that is fixed (number ??).

-- 
レミ・デニ-クールモン
http://www.remlab.net/





More information about the vlc-devel mailing list