[vlc-devel] [PATCH 1/7] video_output: fix source SAR handling

[Steve Lhomme]

On 2020-09-01 13:27, Alexandre Janniaux wrote:
> Hi,
> 
> As mentionned in previous mails, the patchset probably need
> a simple playback check on Android or iOS (any of them) just
> to ensure it works correctly in those cases.

If they don't work with the source.dar/source.crop on startup they are 
likely to fail when they are set dynamically during playback. This 
patchset should not change this behavior. The crop and aspect-ratio are 
applied via vout_SetDisplayCrop() and vout_SetDisplayAspect() on 
startup, just as when a VOUT_CHANGE control changes these values.

The patches are needed because of all the changes in the core, moving 
the crop/ar info into vd->source. There are currently many display 
modules that don't handle it anymore. It's possible ios/android have the 
same problem. But it's unrelated to this patchset.


> Otherwise, LGTM too.
> 
> Regards,
> --
> Alexandre Janniaux
> Videolabs
> 
> On Tue, Sep 01, 2020 at 12:06:32PM +0200, Steve Lhomme wrote:
>> typo introduced in 1964a189e2bfab203c7614265df3ae5ad8f81502
>> ---
>>   src/video_output/video_output.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
>> index 4f48754cf2e..49a1e9653ad 100644
>> --- a/src/video_output/video_output.c
>> +++ b/src/video_output/video_output.c
>> @@ -287,7 +287,7 @@ static void vout_SizeWindow(vout_thread_sys_t *vout,
>>       unsigned w = original->i_visible_width;
>>       unsigned h = original->i_visible_height;
>>       unsigned sar_num = original->i_sar_num;
>> -    unsigned sar_den = original->i_sar_num;
>> +    unsigned sar_den = original->i_sar_den;
>>
>>       switch (sys->source.crop.mode) {
>>           case VOUT_CROP_NONE:
>> --
>> 2.26.2
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>