[vlc-devel] [PATCH 3/8] qml: remove unnecessary shadows on the playlist
Pierre Lamot
pierre at videolabs.io
Tue Sep 1 18:32:05 CEST 2020
bottom and left shadows are not part of the design
top shadow is already attached to the navigation bar
---
.../gui/qt/medialibrary/qml/MainDisplay.qml | 111 +++++-------------
1 file changed, 29 insertions(+), 82 deletions(-)
diff --git a/modules/gui/qt/medialibrary/qml/MainDisplay.qml b/modules/gui/qt/medialibrary/qml/MainDisplay.qml
index ac798eacd2..d1e42fb87f 100644
--- a/modules/gui/qt/medialibrary/qml/MainDisplay.qml
+++ b/modules/gui/qt/medialibrary/qml/MainDisplay.qml
@@ -263,94 +263,41 @@ Widgets.NavigableFocusScope {
}
]
- ColumnLayout {
+
+ PL.PlaylistListView {
+ id: playlist
+
anchors.fill: parent
- spacing: 0
-
- Rectangle
- {
- id: topGlow
- Layout.fillWidth: true
- height: VLCStyle.margin_xxsmall
- visible: playlist.visible
- z: 1
- color: VLCStyle.colors.banner
-
- RectangularGlow {
- anchors.fill: parent
- glowRadius: VLCStyle.dp(8)
- color: VLCStyle.colors.glowColor
- }
+ focus: true
+
+ rightPadding: VLCStyle.applicationHorizontalMargin
+
+ navigationParent: medialibId
+ navigationLeftItem: stackView
+ navigationUpItem: sourcesBanner
+ navigationDownItem: miniPlayer.expanded ? miniPlayer : undefined
+ navigationCancel: function() {
+ mainInterface.playlistVisible = false
+ stackView.forceActiveFocus()
}
- PL.PlaylistListView {
- id: playlist
- Layout.fillWidth: true
- Layout.fillHeight: true
- z: 0
- focus: true
-
- rightPadding: VLCStyle.applicationHorizontalMargin
-
- navigationParent: medialibId
- navigationLeftItem: stackView
- navigationUpItem: sourcesBanner
- navigationDownItem: miniPlayer.expanded ? miniPlayer : undefined
- navigationCancel: function() {
- mainInterface.playlistVisible = false
- stackView.forceActiveFocus()
- }
- Item
- {
- anchors {
- top: parent.top
- left: parent.left
- bottom: parent.bottom
- }
- width: VLCStyle.margin_xxsmall
-
- RectangularGlow {
- anchors.fill: parent
-
- glowRadius: VLCStyle.dp(8)
- color: VLCStyle.colors.glowColor
- }
-
- Widgets.HorizontalResizeHandle {
- id: resizeHandle
- anchors {
- top: parent.top
- bottom: parent.bottom
- left: parent.left
- }
-
- atRight: false
- targetWidth: playlistColumn.width
- sourceWidth: root.width
-
- onWidthFactorChanged: mainInterface.setPlaylistWidthFactor(widthFactor)
- Component.onCompleted: {
- //don't bind just provide the initial value, HorizontalResizeHandle.widthFactor updates itself
- widthFactor = mainInterface.playlistWidthFactor
- }
- }
+ Widgets.HorizontalResizeHandle {
+ id: resizeHandle
+ anchors {
+ top: parent.top
+ bottom: parent.bottom
+ left: parent.left
}
- }
- Rectangle
- {
- id: bottomGlow
- Layout.fillWidth: true
- height: VLCStyle.margin_xxsmall
- visible: playlist.visible
- z: 1
- color: VLCStyle.colors.banner
-
- RectangularGlow {
- anchors.fill: parent
- glowRadius: VLCStyle.dp(8)
- color: VLCStyle.colors.glowColor
+ atRight: false
+ targetWidth: playlistColumn.width
+ sourceWidth: root.width
+
+ onWidthFactorChanged: mainInterface.setPlaylistWidthFactor(widthFactor)
+ Component.onCompleted: {
+ //don't bind just provide the initial value, HorizontalResizeHandle.widthFactor updates itself
+ widthFactor = mainInterface.playlistWidthFactor
}
}
}
--
2.25.1
More information about the vlc-devel
mailing list