[vlc-devel] [PATCH] keystore: accept empty usernamez

[Alexandre Janniaux]

Hi,

On Wed, Sep 02, 2020 at 12:37:43PM +0200, Thomas Guillem wrote:
>
>
> On Wed, Sep 2, 2020, at 11:54, Alexandre Janniaux wrote:
> > Hi,
> >
> > On Wed, Sep 02, 2020 at 11:17:11AM +0200, Thomas Guillem wrote:
> > >
> > >
> > > On Tue, Sep 1, 2020, at 16:40, Alexandre Janniaux wrote:
> > > > Hi,
> > > >
> > > > LGTM for the fix.
> > > >
> > > > Maybe is_credential_valid can be implemented with a new
> > > > capability `keystore validation` which could be implemented
> > > > for each protocol scheme?
> > >
> > > I think each module could handle that themselves.
> >
> > You mean keystore modules? It means that keystore modules
> > would need to know every protocols.
>
> No, I mean access modules.

Seems reasonable indeed.

Regards,
--
Alexandre Janniaux
Videolabs