[vlc-devel] [PATCH 9/9] lua: http: Announce the web interface over mdns

[Rémi Denis-Courmont]

Le keskiviikkona 2. syyskuuta 2020, 16.47.31 EEST Hugo Beauzée-Luyssen a écrit 
:
> Fix #18090
> ---
>  share/lua/intf/http.lua | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/share/lua/intf/http.lua b/share/lua/intf/http.lua
> index ed0c3583eb..06b97ad5a6 100644
> --- a/share/lua/intf/http.lua
> +++ b/share/lua/intf/http.lua
> @@ -330,3 +330,7 @@ password = vlc.var.inherit(nil,"http-password")
>  h = vlc.httpd()
>  load_dir( http_dir )
>  a = h:handler("/art",nil,password,callback_art,nil)
> +sa_entry = vlc.sa.new_entry("VLC Web Interface", "_http._tcp", h:port())
> +if sa_entry then
> +    sa_entry:announce(sa_entry)
> +end

I don't think the HTTP interface should be advertised until it's secured. 
Potential for worms / exploits here.

-- 
Rémi Denis-Courmont
http://www.remlab.net/