[vlc-devel] [PATCH 08/15] kms: use the source format to create the local picture

Steve Lhomme robux4 at ycbcr.xyz
Thu Sep 3 07:52:25 CEST 2020


At this stage the only difference betweeen vd->source and vd->fmt is the SAR.
Since this local picture is only use to copy planes, the SAR is never used.

It's possible that the original code is wrong as it doesn't take in account the
"kms-vlc-chroma" forced chroma that the core will assume is used.
---
 modules/video_output/kms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/video_output/kms.c b/modules/video_output/kms.c
index 6de37d33727..e74ff5a3dab 100644
--- a/modules/video_output/kms.c
+++ b/modules/video_output/kms.c
@@ -578,7 +578,7 @@ static int OpenDisplay(vout_display_t *vd)
 
     picture_resource_t rsc = { 0 };
 
-    sys->picture = picture_NewFromResource(vd->fmt, &rsc);
+    sys->picture = picture_NewFromResource(vd->source, &rsc);
 
     if (!sys->picture)
         goto err_out;
-- 
2.26.2



More information about the vlc-devel mailing list