[vlc-devel] [PATCH 11/15] yuv: use the source visible area to shift pixels

[Rémi Denis-Courmont]

Le torstaina 3. syyskuuta 2020, 9.26.55 EEST Steve Lhomme a écrit :
> On 2020-09-03 7:52, Steve Lhomme wrote:
> > The values are always the same as in the output format.
> 
> In fact they are not, because of video_format_ApplyRotation(). So this
> patch is wrong.
> 
> Dynamic cropping/AR is not handled and pretends to the core that it
> does, so it's probably broken. It should probably return an error when
> that happens and handle RESET_PICTURES. Then a conversion filter to
> match the original format will be added.

There are no reasons to use a conversion filter here. We're just writing pixel 
values and meta to a file.

-- 
Реми Дёни-Курмон
http://www.remlab.net/