[vlc-devel] [RFC] custom module capabilities

[Alexandre Janniaux]

Hi,

Actually what Rémi says. The replacement with macros could be
quite a good thing, but there are two competiting rules between
Remi's post and previous Steve's work.

>     set_capability(VLC_CAPABILITY_DEMUX, xxx)

vs

>     set_demux_callback(Open, score)

Regards,
--
Alexandre Janniaux
Videolabs

On Thu, Sep 03, 2020 at 07:05:12PM +0300, Rémi Denis-Courmont wrote:
> Le torstaina 3. syyskuuta 2020, 18.49.20 EEST Lyndon Brown a écrit :
> > One set of patches switches capabilities over to be enum based. (For
> > which there are advantages such as efficiency and catching mistakes).
>
> If you're concerned with typos in the capability string, you can simply
> replace the strings with macros:
>
> #define VLC_CAPABILITY_DEMUX "demux"
>
> and
>
>     set_capability(VLC_CAPABILITY_DEMUX, xxx)
>
> I don't really follow the efficiency argument. We already have a binary search
> tree for indexing capabilities. An enumeration is likely to cause a lot of
> compatibility problems as capabilities are added and removed.
>
> --
> レミ・デニ-クールモン
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel