[vlc-devel] [PATCH 01/15] display: make vd->owner a const pointer

[Steve Lhomme]

On 2020-09-03 17:48, Rémi Denis-Courmont wrote:
> Le torstaina 3. syyskuuta 2020, 18.11.31 EEST Steve Lhomme a écrit :
>> On 2020-09-03 16:20, Rémi Denis-Courmont wrote:
>>> Le torstaina 3. syyskuuta 2020, 8.52.18 EEST Steve Lhomme a écrit :
>>>> No need to make it writable to modules.
>>>
>>> vd->owner is writable either way. This won't prevent a clueless developer
>>> from doing bad things.
>>
>> You can change the pointer but the content of the pointed struct.
> 
> If you are careless are motivated enough to modify the owner, that makes no
> difference.
> 
> I get it that accidentally modifying the source or configuration could be
> prevented by the patch series, but people should know that they're not
> supposed to modify the owner.

I agree, but this is also for consistency with the rest of the patches. 
In the end only the parts that the display module is allowed to change 
are not const.