[vlc-devel] [PATCH 01/15] display: make vd->owner a const pointer

[Steve Lhomme]

On 2020-09-05 8:36, Rémi Denis-Courmont wrote:
> Le perjantaina 4. syyskuuta 2020, 16.32.48 EEST Rémi Denis-Courmont a écrit :
>> Le perjantaina 4. syyskuuta 2020, 8.19.26 EEST Steve Lhomme a écrit :
>>> I agree, but this is also for consistency with the rest of the patches.
>>
>> 1) It is *not* consistent with the other existing owner structures.
>>
>>> In the end only the parts that the display module is allowed to change
>>> are not const.
>>
>> 2) It cannot remain consistent within vout_display_t, as we could very well
>> add a 'const vout_display_operations *ops;' member that would *not* be read-
>> only for the module - just like we already have vout_window_t.ops.
> 
> With that said, I don't know why vout_display_t even has an owner structure. I
> don't see why it should be reporting the view angle, and every other event was
> already removed or moved to the window.

Otherwise the accelerometer has to be ported to each window handler, 
even the one used for libvlc when rendering to textures. Right now it's 
in the common win32 code.