[vlc-devel] [PATCH] display: don't force a 0 SAR anymore on the display preferred format

Steve Lhomme robux4 at ycbcr.xyz
Mon Sep 7 08:37:14 CEST 2020


In some cases the display modules may rotate the video format, resulting in
inverted and non matching SAR. But in that case the width/height will also be
rotated and thus not matching either.

Also the comparision between the input and preferred format of the display
module explicitly zero the SAR for comparison (although it may hide some needed
conversion).
---
 src/video_output/display.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/video_output/display.c b/src/video_output/display.c
index 0518e7a5908..b76de8ed269 100644
--- a/src/video_output/display.c
+++ b/src/video_output/display.c
@@ -298,8 +298,6 @@ static int vout_display_start(void *func, bool forced, va_list ap)
 
     /* Picture buffer does not have the concept of aspect ratio */
     video_format_Copy(&osys->display_fmt, vd->source);
-    osys->display_fmt.i_sar_num = 0;
-    osys->display_fmt.i_sar_den = 0;
     vd->obj.force = forced; /* TODO: pass to activate() instead? */
 
     int ret = activate(vd, cfg, &osys->display_fmt, context);
-- 
2.26.2



More information about the vlc-devel mailing list