[vlc-devel] [PATCH 5a/5] stream_ReadLine: control maximum length with object variable

Thomas Guillem thomas at gllm.fr
Mon Sep 7 10:21:08 CEST 2020


On Sun, Sep 6, 2020, at 08:47, Rémi Denis-Courmont wrote:
> Le sunnuntaina 6. syyskuuta 2020, 5.46.36 EEST Pierre Ynard via vlc-devel a 
> écrit :
> > Very long lines are occasionally encountered in text web resources such
> > as HTML, JSON or other API data, which the current hardcoded limit can't
> > accommodate. This allows the caller to configure that limit to do so.
> > 
> > The default remains unchanged at 200 kB.
> 
> Which is already insanely high. For comparison, Kate limits lines at 4,096 
> characters by default...
> 
> There are no valid use cases for doing this in Lua. You have not exhibited any 
> line-based file formats that needs larger lines. As François and I already 
> reminded you multiples times, HTML is NOT line-based.

Indeed, HTML is NOT line-based, but I would prefer to increase the ReadLine limit for 3.0 (using first Pierre's proposal) and fix the lua's code to not use ReadLine in 4.0.

> 
> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list