[vlc-devel] [PATCH 4/5] stream_ReadLine: support arbitrary length limit

[Thomas Guillem]

Come on, there is no need to get worked up.

You both raised valid points.

- Rémi doesn't want to extend ReadLine for html parsing because html parsing should not be done by line. He is right on that point.

- Pierre want to fix youtube playback. This is essential for VLC 3.0 users. Doing a quick fix to increase the maximum read line for the youtube case seems to be a very reasonable fix for 3.0. It is reasonable because he won't lead to any regressions, and we don't have to change the whole youtube parser.

We have only two choices now:
 - Fix the youtube lua parser for 4.0 and backport it to 3.0.
 - Apply Pierre's patch

My main question is : how long will it take to fix the lua parsing to not use readline?

I don't really understand the purpose of readline here, since a html element can break into multiples lines anyway.
What you could do instead, is creating a ReadElements in lua, that read a chunk of data and ensure the buffer starts with a '<' and ends with a '>' (and keep the part past the last '>' for the next read).

Sorry, if I didn't read all your arguments (it is long...).

On Mon, Sep 7, 2020, at 19:33, Pierre Ynard via vlc-devel wrote:
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> Attachments:
> * Email.eml