[vlc-devel] [PATCH 0/5] Addressing Hugo Beauzée-Luyssen feedback

[Hugo Beauzée-Luyssen]

On Sun, Sep 6, 2020, at 9:39 AM, Alon Sirota wrote:
> Link to feedback: 
> https://mailman.videolan.org/pipermail/vlc-devel/2020-August/136631.html
> 
> Alon Sirota (5):
>   Add VLSub feature: Download multiple subtitles
>   VLSub: Reindent block to original indentations
>   VLSub: Refactor get_all_sel
>   VLSub: Remove self explanatory comment
>   VLSub: Preserve table ordering
> 
>  share/lua/extensions/VLSub.lua | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 

Hi,

Thanks a lot for updating the patchset! The rule of thumb is to avoid sending patches that correct patches from the same set, so here the expected result would have been to squash all commits in the first one.
To illustrate, I took the liberty of ammending your set and pushing it there:
https://code.videolan.org/chouquette/vlc/-/commit/cf9bac639fdbc1a6e240f37c3f6cb39e5070b1a5
https://code.videolan.org/chouquette/vlc/-/commit/95a18f7b5ab202b2bf636ffb06d654fc19c1806b

In my opinion, the result is much more readable now! If that's OK with you, I'll push this version

Thanks for your contribution!

Regards,

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr