[vlc-devel] [PATCH 2/6] executor: add unit tests

[Alexandre Janniaux]

Hi,

On Mon, Sep 07, 2020 at 07:16:07PM +0200, Romain Vimont wrote:
> On Mon, Sep 07, 2020 at 06:27:37PM +0200, Alexandre Janniaux wrote:
> > Hi,
> >
> > On Mon, Sep 07, 2020 at 05:40:07PM +0200, Romain Vimont wrote:
> > > +    /* Wait a bit (in two lines to avoid harmful_delay() warning) */
> >
> > To avoid harmful_delay() warnings, you can use (vlc_tick_sleep)(foo);
>
> Thank you for the tip.
>
> However, I'm not fan of this hack, I find it confusing and it "breaks"
> tools like cscope/ctags.
>
> > > +    vlc_tick_t delay = VLC_TICK_FROM_MS(150);
> > > +    vlc_tick_sleep(delay);

Yes, but it could be argued that it's not much prettier
to hide the warnings by splitting the sleeping calls.
It's probably better to leave the warning triggers here
then.

Regards,
--
Alexandre Janniaux
Videolabs