[vlc-devel] [PATCH] display: use an optional callback to set the viewpoint

[Rémi Denis-Courmont]

Le tiistaina 8. syyskuuta 2020, 11.46.38 EEST Steve Lhomme a écrit :
> On 2020-09-08 10:16, Alexandre Janniaux wrote:
> > Hi,
> > 
> > On Mon, Sep 07, 2020 at 08:37:49AM +0200, Steve Lhomme wrote:
> >> In the future it may be called directly from the thread generating the
> >> event to lower the latency.
> > 
> > Sorry I missed this yesterday, but the commit message doesn't
> > look correct. Being a control or being a callback will never
> > lower the latency so the commit message is not adapted to the
> > commit itself.
> 
> The control should be called from a determined thread,

I don't think that's the case. The control is called with the display locked, 
so the display needs not be reentrant. This is a common convention for all 
capabilities except for the logger.

But there are no guarantees that controls are tied to a given thread, and I 
don't think that they even are in HEAD.


-- 
Rémi Denis-Courmont
http://www.remlab.net/