[vlc-devel] [PATCH] contrib: aom: use NASM instead of YASM

[Alexandre Janniaux]

Hi,

This might not be needed given how the CMakeFile is written:

```

if("${AOM_TARGET_CPU}" STREQUAL "x86" OR "${AOM_TARGET_CPU}" STREQUAL "x86_64")
  find_program(AS_EXECUTABLE yasm $ENV{YASM_PATH})
  if(NOT AS_EXECUTABLE OR ENABLE_NASM)
    unset(AS_EXECUTABLE CACHE)
    find_program(AS_EXECUTABLE nasm $ENV{NASM_PATH})
    if(AS_EXECUTABLE)
      test_nasm()
    endif()
  endif()

  if(NOT AS_EXECUTABLE)
    message(
      FATAL_ERROR
        "Unable to find assembler. Install 'yasm' or 'nasm.' "
        "To build without optimizations, add -DAOM_TARGET_CPU=generic to "
        "your cmake command line.")
  endif()
```

But it could be a plan if we plan to remove yasm usage completely.

Regards,
--
Alexandre Janniaux
Videolabs

On Thu, Sep 10, 2020 at 01:07:01PM +0200, Alexandre Janniaux wrote:
> ---
>  contrib/src/aom/rules.mak | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/contrib/src/aom/rules.mak b/contrib/src/aom/rules.mak
> index ccf6491582..6599b082cb 100644
> --- a/contrib/src/aom/rules.mak
> +++ b/contrib/src/aom/rules.mak
> @@ -44,7 +44,8 @@ AOM_CONF := \
>  	-DENABLE_TESTS=OFF \
>  	-DCONFIG_INSTALL_BINS=0 \
>  	-DCONFIG_INSTALL_DOCS=0 \
> -	-DCONFIG_DEPENDENCY_TRACKING=0
> +	-DCONFIG_DEPENDENCY_TRACKING=0 \
> +	-DENABLE_NASM=ON
>
>  ifndef BUILD_ENCODERS
>  AOM_CONF += -DCONFIG_AV1_ENCODER=0
> --
> 2.28.0
>