[vlc-devel] [PATCH 2/2] demux: mkv: have mouse events registration non fatal

Steve Lhomme robux4 at ycbcr.xyz
Fri Sep 11 10:30:05 CEST 2020


On 2020-09-11 9:32, Francois Cartegnie wrote:
> Le 11/09/2020 à 08:08, Steve Lhomme a écrit :
>> Might be OK theoretically. But it doesn't seem to be a real life case.
>> In es_out.c, ES_OUT_VOUT_SET_MOUSE_EVENT fails only if the track is not
>> a video one. And it's already checked in AddES(). The same check is done
>> in dvdnav or bluray.
> 
> es_out.c is one implementation of es_out_t.
> 
> Other implementations shouldn't be required to provide mouse events support.

I'm just saying, it's not going to solve any problem, but it's not wrong 
and probably better.


More information about the vlc-devel mailing list