[vlc-devel] [PATCHv4 05/12] contrib: add cargo

[Thomas Guillem]

On Fri, Sep 11, 2020, at 08:40, Martin Storsjö wrote:
> On Tue, 8 Sep 2020, Thomas Guillem wrote:
> 
> > From: Kartik Ohri <kartikohri13 at gmail.com>
> >
> > This will install rustup, cargo, and cargo-c into contrib/bin/.cargo
> > This installation will be used by default for all rust contrib builds.
> >
> > The correct cargo target will be automatically installed when needed.
> > ---
> > contrib/src/cargo/SHA512SUMS |  1 +
> > contrib/src/cargo/rules.mak  | 28 ++++++++++++++++++++++++++++
> > 2 files changed, 29 insertions(+)
> > create mode 100644 contrib/src/cargo/SHA512SUMS
> > create mode 100644 contrib/src/cargo/rules.mak
> 
> For more exotic targets, this fails like this:
> 
> error: toolchain 'stable-x86_64-unknown-linux-gnu' does not contain 
> component 'rust-std' for target 'aarch64-pc-windows-gnu'
> ../src/cargo/rules.mak:31: recipe for target '.cargo' failed
> make: *** [.cargo] Error 1
> 
> 
> Can these contrib components (rust/cargo and rav1e) skipped for 
> armv7/aarch64-windows?

There is a aarch64-pc-windows-msvc target. Can it be used?
And indeed, we can skip targets. If RUST_TARGET is not defined, Rust contribs won't be built.

cf. the IOS case:

else ifdef HAVE_IOS
ifneq ($(ARCH),arm) # iOS 32bit is Tier 3
ifndef HAVE_TVOS # tvOS is Tier 3
RUST_TARGET = $(ARCH)-apple-ios
endif
endif

We skip ios-arm et aarch64-tvos here.

> 
> // Martin
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel