[vlc-devel] [PATCH] contrib: rust: Only enable rust on known supported windows architectures

[Steve Lhomme]

On 2020-09-11 13:30, Thomas Guillem wrote:
> LGTM.
> 
> Could we add armv7/aarch64-windows targets into our CI? I focused my efforts on all 16 targets handled by our CI.

Technically it's already handled by the LLVM mingw64 dockers as they 
contain all 4 Windows targets (sorry MIPS, PowerPC and older arms).

So it's just a matter of adding a few lines to the gitlab CI file. No 
idea if the builds would work though.

> On Fri, Sep 11, 2020, at 12:31, Steve Lhomme wrote:
>> Oh, right. I didn't notice.
>>
>> On 2020-09-11 12:19, Martin Storsjö wrote:
>>> On Fri, 11 Sep 2020, Steve Lhomme wrote:
>>>
>>>> What about x86 32 bits ?
>>>
>>> That's already covered in the existing 2 lines just above the code I'm
>>> modifying.
>>>
>>> // Martin
>>>
>>>
>>>> On 2020-09-11 12:00, Martin Storsjö wrote:
>>>>> Instead of adding explicit opt-out for the known unsupported
>>>>> architectures (armv7, aarch64), just enable it for the specific
>>>>> architectures we know are supported.
>>>>> ---
>>>>>    contrib/src/main-rust.mak | 4 +++-
>>>>>    1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/contrib/src/main-rust.mak b/contrib/src/main-rust.mak
>>>>> index e31629dea6..edd9c47467 100644
>>>>> --- a/contrib/src/main-rust.mak
>>>>> +++ b/contrib/src/main-rust.mak
>>>>> @@ -6,8 +6,10 @@
>>>>>    ifdef HAVE_WIN32
>>>>>    ifeq ($(HOST),i686-w64-mingw32)
>>>>>    RUST_TARGET = i686-pc-windows-gnu # ARCH is i386
>>>>> -else
>>>>> +else ifeq ($(HOST),x86_64-w64-mingw32)
>>>>>    RUST_TARGET = $(ARCH)-pc-windows-gnu
>>>>> +else
>>>>> +# Not supported on armv7/aarch64 yet
>>>>>    endif
>>>>>    else ifdef HAVE_ANDROID
>>>>>    RUST_TARGET = $(HOST)
>>>>> -- 
>>>>> 2.17.1
>>>>>
>>>>> _______________________________________________
>>>>> vlc-devel mailing list
>>>>> To unsubscribe or modify your subscription options:
>>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>>>
>>>> _______________________________________________
>>>> vlc-devel mailing list
>>>> To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>