[vlc-devel] [PATCH 3/3] aout: lower the error level in case of passthrough error

Thomas Guillem thomas at gllm.fr
Tue Sep 15 16:36:20 CEST 2020


This error message was confusing the user since the audio playback
works normally after getting such error message.
---
 src/audio_output/output.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/audio_output/output.c b/src/audio_output/output.c
index e144159e05a..1d4c01421d2 100644
--- a/src/audio_output/output.c
+++ b/src/audio_output/output.c
@@ -605,7 +605,11 @@ int aout_OutputNew (audio_output_t *aout)
     vlc_mutex_unlock(&owner->lock);
     if (ret)
     {
-        msg_Err (aout, "failed to start audio output");
+        if (AOUT_FMT_LINEAR(fmt))
+            msg_Err (aout, "failed to start audio output");
+        else
+            msg_Warn (aout, "failed to start passthrough audio output, "
+                      "failing back to linear format");
         return -1;
     }
     assert(aout->flush && aout->play && aout->time_get && aout->pause);
-- 
2.28.0



More information about the vlc-devel mailing list