[vlc-devel] [PATCH 01/14] vlm: remove custom logger from media

Romain Vimont rom1v at videolabs.io
Tue Sep 15 19:37:33 CEST 2020


No message is ever logged for a media.
---
 src/input/vlm.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/src/input/vlm.c b/src/input/vlm.c
index 116fc5296e..bd7205a0a3 100644
--- a/src/input/vlm.c
+++ b/src/input/vlm.c
@@ -462,7 +462,6 @@ static int vlm_ControlMediaChange( vlm_t *p_vlm, vlm_media_t *p_cfg )
 static int vlm_ControlMediaAdd( vlm_t *p_vlm, vlm_media_t *p_cfg, int64_t *p_id )
 {
     vlm_media_sys_t *p_media;
-    char *header;
 
     if( vlm_MediaDescriptionCheck( p_vlm, p_cfg ) || vlm_ControlMediaGetByName( p_vlm, p_cfg->psz_name ) )
     {
@@ -475,21 +474,6 @@ static int vlm_ControlMediaAdd( vlm_t *p_vlm, vlm_media_t *p_cfg, int64_t *p_id
     if( !p_media )
         return VLC_ENOMEM;
 
-    if( asprintf( &header, _("Media: %s"), p_cfg->psz_name ) == -1 )
-    {
-        vlc_object_delete(p_media);
-        return VLC_ENOMEM;
-    }
-
-    p_media->obj.logger = vlc_LogHeaderCreate( p_media->obj.logger, header );
-    free( header );
-
-    if( p_media->obj.logger == NULL )
-    {
-        vlc_object_delete(p_media);
-        return VLC_ENOMEM;
-    }
-
     vlm_media_Copy( &p_media->cfg, p_cfg );
     p_media->cfg.id = p_vlm->i_id++;
     /* FIXME do we do something here if enabled is true ? */
@@ -523,7 +507,6 @@ static int vlm_ControlMediaDel( vlm_t *p_vlm, int64_t id )
     vlm_media_Clean( &p_media->cfg );
 
     TAB_REMOVE( p_vlm->i_media, p_vlm->media, p_media );
-    vlc_LogDestroy( p_media->obj.logger );
     vlc_object_delete(p_media);
 
     return VLC_SUCCESS;
-- 
2.28.0



More information about the vlc-devel mailing list