[vlc-devel] [PATCH 09/21] video_output: don't set a value on unused variable

Steve Lhomme robux4 at ycbcr.xyz
Wed Sep 16 08:05:23 CEST 2020


On 2020-09-15 18:05, Rémi Denis-Courmont wrote:
> Le tiistaina 15. syyskuuta 2020, 15.36.14 EEST Steve Lhomme a écrit :
>> At this stage paused will not be used anymore. No need to set the value.
>>
>> We keep the comment for the unlikely case where next_system_pts is
>> INT64_MAX. ---
>>   src/video_output/video_output.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/src/video_output/video_output.c
>> b/src/video_output/video_output.c index 6e78e7f71d3..6d5a7e9e669 100644
>> --- a/src/video_output/video_output.c
>> +++ b/src/video_output/video_output.c
>> @@ -1528,7 +1528,6 @@ static int ThreadDisplayPicture(vout_thread_sys_t
>> *vout, vlc_tick_t *deadline) {
>>               /* The clock was just paused, don't display the next frame
>> (keep * the current one). */
>> -            paused = true;
>>           }
>>           else
>>           {
> 
> Really should invert the condition and remove the empty block.

OK


More information about the vlc-devel mailing list