[vlc-devel] [PATCH 05/21] video_output: rename drop_next_frame to display_next_frame

[Steve Lhomme]

On 2020-09-16 8:03, Steve Lhomme wrote:
> On 2020-09-15 18:03, Rémi Denis-Courmont wrote:
>> Le tiistaina 15. syyskuuta 2020, 15.36.10 EEST Steve Lhomme a écrit :
>>> That's what it really does. It actually forces to render the next frame
>>> because we skip the current one.
>>
>> AFAICT, what it really does is skip this/the current frame.
> 
> That's another way to see it. But in frame by frame mode this flag is 
> set and if there is no next frame, nothing is rendered. So it's really 
> about what you want to display, rather than what you want to skip.

BTW, in normal playback the next frame is always grabbed if it's 
available. If the display date is before "now" it replaces the current 
frame with the same flag. That means the next frame is already late so 
we might as well display that one.

I think this should be improved to skip all the late frames (except 
maybe the last late one).

On the other hand, if the current frame is not late, the next frame 
won't be either, so there is no need to get that next frame, and pass it 
through the deinterlacer, and waste valuable time when all we want is to 
display the current frame in time.

I'll try to come up with a solution to clean all this.