[vlc-devel] [PATCH 00/14] Move VLM implementation to a module

Jean-Baptiste Kempf jb at videolan.org
Wed Sep 16 08:15:23 CEST 2020


On Wed, 16 Sep 2020, at 07:49, Rémi Denis-Courmont wrote:
> Le keskiviikkona 16. syyskuuta 2020, 0.04.40 EEST Jean-Baptiste Kempf a écrit 
> > > I proposed to remove the completely broken VLM schedules and retain the
> > > clunky but mostly not broken VLM broadcasts. I'd still like to know what
> > > OS supports VLM and does not support some form of scheduled tasks...
> > 
> > Numerous versions of Windows 10, for example.
> 
> No. There's millions of ways to do this on Windows 10.

Not all the Windows 10 versions support that.

> > macOS scheduling is very hard to do, for normal users.
> 
> It's not as hard as figuring out how to use the VLM schedules (an then figuring 
> out how to work around its complete brokeness).

But who speaks about VLM?

We want to be able to have the UI the "I want to record this, at this hour".
We discussed that feature many times.

Refactoring the VLM schedules and fixing them can lead to this feature. And especially if that allows to fix broken schedules.
But it is not, if every patch is bikeshed to death.

You cannot refuse evolutions, step-by-step, it must be perfect before entering the codebase.
This is not real life, and this is not VLC.

And features that are removed are 100x times harder to make them back, because if must be perfect.

> You said that removing objectively broken VLM schedules was not 
> acceptable 
> because they should be fixed. And here we have a patch that breaks log 
> prefixes, 
> and somehow that's okay. Talk about being consistent.

Then, say "this break log prefixes" and see how we can fix that.

> The rest is just moving code around at equal complexity, and adding one or two 
> layers of wrappers on the existing code.

Which is what we said we wanted: remove code from the core, notably parsing ones.
So that they can be 

> The whole point of a code review process is to reject what is broken/
> incorrect.

Yet, the whole VLC is broken and incorrect in so many ways.
There must be a balance. VLC is an end-user project, not a research or a compiler project.

"VLM is broken", yet, we see numerous people use it every day.
So broken is not a binary situation.



-- 
Jean-Baptiste Kempf -  President
+33 672 704 734


More information about the vlc-devel mailing list